All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shi Weihua <shiwh@cn.fujitsu.com>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check
Date: Wed, 20 Feb 2008 10:59:09 +0800	[thread overview]
Message-ID: <47BB977D.5090406@cn.fujitsu.com> (raw)
In-Reply-To: <20080220024928.0EE172701BA@magilla.localdomain>

Roland McGrath wrote::
>> I spent some time read you mail carefully and dig into the code again.
>>
>> And yes, you are right. It's possible that SA_ONSTACK has been cleared
>> before the second signal on the same stack comes.
> 
> It's not necessary for SA_ONSTACK to have "been cleared", by which I assume
> you mean a sigaction call with SA_ONSTACK not set in sa_flags.  That is
> indeed possible, but it's not the only case your patch broke.  It can just
> be a different signal whose sigaction never had SA_ONSTACK, when you are
> still on the signal stack from an earlier signal that did have SA_ONSTACK.

Thanks for your explanation.

> 
>> So this patch is wrong  :( . I will revise the other 4 patches.
> 
> For 2 and 3, I would rather just wait until we unify signal.c anyway.

Ok. I see.


  reply	other threads:[~2008-02-20  3:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 10:22 [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check Shi Weihua
2008-02-18 13:47 ` Ingo Molnar
2008-02-19  0:58   ` Shi Weihua
2008-02-19 18:50     ` Roland McGrath
2008-02-20  0:49       ` Shi Weihua
2008-02-20  1:18         ` Roland McGrath
2008-02-20  1:35           ` Shi Weihua
2008-02-20  1:44             ` Roland McGrath
2008-02-20  2:23               ` Shi Weihua
2008-02-20  2:49                 ` Roland McGrath
2008-02-20  2:59                   ` Shi Weihua [this message]
2008-02-20  5:54                   ` Harvey Harrison
2008-02-20  7:59                     ` Roland McGrath
2008-02-20 10:27                   ` Ingo Molnar
2008-02-18 18:05 ` Valdis.Kletnieks
2008-02-19  2:11   ` Shi Weihua
2008-02-19  2:19 ` Shi Weihua
2008-02-19 11:05   ` Ingo Molnar
2008-02-19 23:21     ` Paul Mackerras
2008-02-19 23:25       ` H. Peter Anvin
2008-02-20  0:03         ` Roland McGrath
2008-02-20  0:04       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BB977D.5090406@cn.fujitsu.com \
    --to=shiwh@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.