From: Patrick McHardy <kaber@trash.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "Linux 802.1Q VLAN" <vlan@candelatech.com>,
Stephen Anderson <smanders@broadcom.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [VLAN] vlan_skb_recv
Date: Wed, 20 Feb 2008 13:27:10 +0100 [thread overview]
Message-ID: <47BC1C9E.5050104@trash.net> (raw)
In-Reply-To: <47B31B96.7010801@candelatech.com>
Ben Greear wrote:
> Stephen Anderson wrote:
>> Hello,
>>
>> To help increase throughput and bypass the backlog queue, I changed the
>> netif_rx() to netif_receive_skb() in vlan_skb_recv(). What's the
>> argument for using netif_rx() other than legacy maintenance? At this
>> point, interrupt context should not be an issue. Layer 2 performance
>> has been a big focus in my area of development.
I guess the only point is to reduce stack usage. Its probably not
a problem with only VLAN, but it might be with further tunnels,
IPsec, ...
>> I'm sure you have seen many attempts to implement a single VLAN aware
>> IVL FDB in the past and I was wondering which attempt do you feel was
>> the best? Have you ever considered integrating your VLAN support
>> natively into the bridging code base or know of any attempts to do just
>> that?
Without having thought about this much, it seems to me that
it needs to be integrated in the bridge fdb to work properly.
parent reply other threads:[~2008-02-20 12:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <47B31B96.7010801@candelatech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BC1C9E.5050104@trash.net \
--to=kaber@trash.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=smanders@broadcom.com \
--cc=vlan@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.