From: Daniel Drake <dsd@gentoo.org>
To: "Luis R. Rodriguez" <mcgrof@winlab.rutgers.edu>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Patch for compat-wireless-2.6
Date: Wed, 20 Feb 2008 14:01:59 +0000 [thread overview]
Message-ID: <47BC32D7.3040900@gentoo.org> (raw)
In-Reply-To: <43e72e890802191535i5bd89432rfed0f4cf3e375c29@mail.gmail.com>
Luis R. Rodriguez wrote:
>> +--- a/drivers/net/wireless/zd1211rw/zd_chip.h 2008-02-15 16:29:43.000000000 -0500
>> ++++ b/drivers/net/wireless/zd1211rw/zd_chip.h 2008-02-15 16:29:43.000000000 -0500
>> +@@ -890,7 +890,7 @@ int zd_chip_lock_phy_regs(struct zd_chip *chip);
>> + int zd_chip_unlock_phy_regs(struct zd_chip *chip);
>> +
>> + enum led_status {
>> +- LED_OFF = 0,
>> ++ LED_OFF_ZD = 0,
>> + LED_SCANNING = 1,
>> + LED_ASSOCIATED = 2,
>> + };
>
> This could possibly go upstream so we don't have to keep an extra
> patch around. Up to zd guys though. If not we'll have to keep updating
> this hunk as the driver changes. Not a big issue. This is just so we
> can keep including from compat.h leds.h which has its own definition
> of LEDS_OFF.
Feel free to submit a patch adding a ZD_ prefix to all the enum members.
Daniel
prev parent reply other threads:[~2008-02-20 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 15:12 Patch for compat-wireless-2.6 Hauke Mehrtens
2008-02-19 23:35 ` Luis R. Rodriguez
2008-02-20 14:01 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BC32D7.3040900@gentoo.org \
--to=dsd@gentoo.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@winlab.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.