From: Randy Dunlap <randy.dunlap@oracle.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: lkml <linux-kernel@vger.kernel.org>, gregkh <greg@kroah.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] firmware: fix a few build errors
Date: Wed, 20 Feb 2008 13:56:57 -0800 [thread overview]
Message-ID: <47BCA229.1090406@oracle.com> (raw)
In-Reply-To: <6196E805-23A7-47EA-813C-1FDDEA8949FC@holtmann.org>
Marcel Holtmann wrote:
> Hi Randy,
>
>> Fix one typo (comma to semi-colon).
>> Fix sysfs externs (just use sysfs.h for prototypes).
>>
>> Documentation/firmware_class/firmware_sample_firmware_class.c:37:
>> error: conflicting types for 'sysfs_remove_bin_file'
>> include/linux/sysfs.h:100: error: previous declaration of
>> 'sysfs_remove_bin_file' was here
>>
>> Still has a build error:
>> ERROR: "firmware_class"
>> [samples/firmware_class/firmware_sample_firmware_class.ko]
>> undefined!
>
> while you are at it, can you also fix the broken coding style in it?
Greg will do that while he is fixing the <firmware_class> data build error. :)
--
~Randy
prev parent reply other threads:[~2008-02-20 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 21:21 [PATCH 2/2] firmware: fix a few build errors Randy Dunlap
2008-02-20 21:49 ` Marcel Holtmann
2008-02-20 21:56 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BCA229.1090406@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.