From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clemens Ladisch Subject: Re: [PATCH] Fix a compile warning under gcc-4.2.3. Date: Thu, 21 Feb 2008 09:48:30 +0100 Message-ID: <47BD3ADE.8040501@ladisch.de> References: <1203528197-24227-1-git-send-email-roysjosh@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com [66.111.4.27]) by alsa0.perex.cz (Postfix) with ESMTP id AF24524339 for ; Thu, 21 Feb 2008 09:46:43 +0100 (CET) In-Reply-To: <1203528197-24227-1-git-send-email-roysjosh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Joshua Roys Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Sm9zaHVhIFJveXMgd3JvdGU6Cj4gc291bmQvY29yZS9pbml0LmM6IEluIGZ1bmN0aW9uIOKAmHNu ZF9jYXJkX2Rpc2Nvbm5lY3TigJk6Cj4gc291bmQvY29yZS9pbml0LmM6MzA3OiB3YXJuaW5nOiB0 aGUgYWRkcmVzcyBvZiDigJhzbmRfc2h1dGRvd25fZl9vcHPigJkgd2lsbCBhbHdheXMgZXZhbHVh dGUgYXMg4oCYdHJ1ZeKAmQo+Cj4gU2lnbmVkLW9mZi1ieTogSm9zaHVhIFJveXMgPHJveXNqb3No QGdtYWlsLmNvbT4KPiAtLS0KPiAgc291bmQvY29yZS9pbml0LmMgfCAgICAxIC0KPiAgMSBmaWxl cyBjaGFuZ2VkLCAwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvc291bmQvY29yZS9pbml0LmMgYi9zb3VuZC9jb3JlL2luaXQuYwo+IGluZGV4IDJjYjcwOTku LjFhZmM1OGIgMTAwNjQ0Cj4gLS0tIGEvc291bmQvY29yZS9pbml0LmMKPiArKysgYi9zb3VuZC9j b3JlL2luaXQuYwo+IEBAIC0zMDQsNyArMzA0LDYgQEAgaW50IHNuZF9jYXJkX2Rpc2Nvbm5lY3Qo c3RydWN0IHNuZF9jYXJkICpjYXJkKQo+ICAJCWxpc3RfYWRkKCZtZmlsZS0+c2h1dGRvd25fbGlz dCwgJnNodXRkb3duX2ZpbGVzKTsKPiAgCQlzcGluX3VubG9jaygmc2h1dGRvd25fbG9jayk7Cj4K PiAtCQlmb3BzX2dldCgmc25kX3NodXRkb3duX2Zfb3BzKTsKPiAgCQltZmlsZS0+ZmlsZS0+Zl9v cCA9ICZzbmRfc2h1dGRvd25fZl9vcHM7Cj4gIAkJCj4gIAkJbWZpbGUgPSBtZmlsZS0+bmV4dDsK ClRoaXMgY2hhbmdlIG1heSBnZXQgcmlkIG9mIHRoZSB3YXJuaW5nLCBidXQgaXMgaGFzIHRoZSBz bGlnaHQKZGlzYWR2YW50YWdlIHRoYXQgdGhlIGtlcm5lbCB3aWxsIGJsb3cgdXAgaWYgeW91IHRy eSB0byB1bmxvYWQgdGhlIHNvdW5kCm1vZHVsZXMgYmVmb3JlIGFsbCBkZXZpY2UgZmlsZXMgaGF2 ZSBiZWVuIGNsb3NlZC4KCklmIHlvdSB3YW50IHRvIGdldCByaWQgb2YgdGhpcyB3YXJuaW5nLCB0 ZWxsIHRoZSBjb21waWxlciB0aGF0IGZvcHNfZ2V0Cmtub3dzIHdoYXQgaXQgZG9lczsgb3IgdHJ5 IG1ha2luZyBmb3BzX2dldCBhbiBpbmxpbmUgZnVuY3Rpb24gaW5zdGVhZCBvZgphIG1hY3JvLgoK ClJlZ2FyZHMsCkNsZW1lbnMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qu b3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNh LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759896AbYBUIq6 (ORCPT ); Thu, 21 Feb 2008 03:46:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754290AbYBUIqp (ORCPT ); Thu, 21 Feb 2008 03:46:45 -0500 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:44749 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755781AbYBUIqo (ORCPT ); Thu, 21 Feb 2008 03:46:44 -0500 X-Sasl-enc: XmLlECQv2wwhWMEMgAhECvLSKWbg8QH4vl0jaMOlrYWA 1203583602 Message-ID: <47BD3ADE.8040501@ladisch.de> Date: Thu, 21 Feb 2008 09:48:30 +0100 From: Clemens Ladisch User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Joshua Roys CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] [alsa-devel] Fix a compile warning under gcc-4.2.3. References: <1203528197-24227-1-git-send-email-roysjosh@gmail.com> In-Reply-To: <1203528197-24227-1-git-send-email-roysjosh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joshua Roys wrote: > sound/core/init.c: In function ‘snd_card_disconnect’: > sound/core/init.c:307: warning: the address of ‘snd_shutdown_f_ops’ will always evaluate as ‘true’ > > Signed-off-by: Joshua Roys > --- > sound/core/init.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/core/init.c b/sound/core/init.c > index 2cb7099..1afc58b 100644 > --- a/sound/core/init.c > +++ b/sound/core/init.c > @@ -304,7 +304,6 @@ int snd_card_disconnect(struct snd_card *card) > list_add(&mfile->shutdown_list, &shutdown_files); > spin_unlock(&shutdown_lock); > > - fops_get(&snd_shutdown_f_ops); > mfile->file->f_op = &snd_shutdown_f_ops; > > mfile = mfile->next; This change may get rid of the warning, but is has the slight disadvantage that the kernel will blow up if you try to unload the sound modules before all device files have been closed. If you want to get rid of this warning, tell the compiler that fops_get knows what it does; or try making fops_get an inline function instead of a macro. Regards, Clemens