From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@suse.de>
Subject: Re: [PATCH] blktap: qcow2 image format support
Date: Thu, 21 Feb 2008 10:32:09 +0100
Message-ID: <47BD4519.1030408@suse.de>
References: <C3E2ED8C.1430F%Keir.Fraser@cl.cam.ac.uk>
	<200802211007.14443.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200802211007.14443.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Christoph Egger schrieb:
> On Thursday 21 February 2008 09:57:48 Keir Fraser wrote:
> IMO, _all_ blktap drivers need some code refactoring. There is a lot of
> duplicated code across all drivers
> that can be moved into a blktap/drivers/blk-common.c.

Yes, I think you're right on that. I noticed this especially with the
aio function which are duplicated in each single driver. I decided not
to fix this with the qcow2 patch as it is a different problem, but it
could be a good next step.

Kevin