From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code
Date: Thu, 21 Feb 2008 11:52:56 -0800 [thread overview]
Message-ID: <47BDD698.9000906@zytor.com> (raw)
In-Reply-To: <20080221195022.GA6772@cvg>
Cyrill Gorcunov wrote:
> This patch replaces 4096 numeric constant with PAGE_SIZE macro.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> Text segments of old and new files *are* the same so
> it wouldn't break current kernel.
>
NAK.
This is NOT PAGE_SIZE (even though the two values are coincidentally the
same, for historical reasons.)
-hpa
next prev parent reply other threads:[~2008-02-21 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 19:50 [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code Cyrill Gorcunov
2008-02-21 19:52 ` H. Peter Anvin [this message]
2008-02-21 19:56 ` Cyrill Gorcunov
2008-02-21 19:59 ` H. Peter Anvin
2008-02-21 20:00 ` Cyrill Gorcunov
2008-02-21 20:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BDD698.9000906@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.