From: Jeremy Fitzhardinge <jeremy@goop.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 21/28] ia64/xen: define xen related address conversion
Date: Thu, 21 Feb 2008 23:45:05 +0000 [thread overview]
Message-ID: <47BE0D01.4020902@goop.org> (raw)
yamahata@valinux.co.jp wrote:
> diff --git a/include/asm-ia64/page.h b/include/asm-ia64/page.h
> index 4999a6c..effd2af 100644
> --- a/include/asm-ia64/page.h
> +++ b/include/asm-ia64/page.h
> @@ -227,4 +227,15 @@ get_order (unsigned long size)
> (((current->personality & READ_IMPLIES_EXEC) != 0) \
> ? VM_EXEC : 0))
>
> +#ifndef __ASSEMBLY__
> +
> +#include <linux/kernel.h>
>
Why? asm-ia64/xen/page.h already includes this.
> +
> +#ifdef CONFIG_XEN
> +
> +#include <asm/xen/page.h>
>
This shouldn't be necessary; anyone wanting Xen-specific definitions
should explicitly include <xen/page.h>.
> +
> +#endif /* CONFIG_XEN */
> +#endif /* __ASSEMBLY__ */
> +
> #endif /* _ASM_IA64_PAGE_H */
> diff --git a/include/asm-ia64/xen/page.h b/include/asm-ia64/xen/page.h
> new file mode 100644
> index 0000000..9ab8148
> --- /dev/null
> +++ b/include/asm-ia64/xen/page.h
> @@ -0,0 +1,19 @@
> +#ifndef _ASM_IA64_MADDR_H
> +#define _ASM_IA64_MADDR_H
> +
> +#include <linux/kernel.h>
> +#include <asm/xen/hypervisor.h>
> +#include <asm/xen/hypercall.h>
> +#include <xen/features.h>
> +#include <xen/interface/xen.h>
> +
> +#define mfn_to_pfn(mfn) (mfn)
> +#define pfn_to_mfn(pfn) (pfn)
> +
> +#define mfn_to_virt(mfn) (__va((mfn) << PAGE_SHIFT))
> +#define virt_to_mfn(virt) (__pa(virt) >> PAGE_SHIFT)
> +#define virt_to_machine(virt) __pa(virt) /* for tpmfront.c */
> +
> +#define set_phys_to_machine(pfn, mfn) do { } while (0)
>
Probably worth turning these into inlines so that they get properly
typechecked. Especially things like set_phys_to_machine(), which
doesn't use its arguments.
J
next reply other threads:[~2008-02-21 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:45 Jeremy Fitzhardinge [this message]
2008-02-22 5:10 ` [PATCH 21/28] ia64/xen: define xen related address conversion helper functions for domU Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BE0D01.4020902@goop.org \
--to=jeremy@goop.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.