All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Andreas Winkelbauer <andreas.winkelbauer@gmx.at>
Cc: kvm-devel@lists.sourceforge.net, arne.brutschy@ulb.ac.be
Subject: Re: [PATCH] fix widescreen resolution issues (v2)
Date: Fri, 22 Feb 2008 09:45:34 +0200	[thread overview]
Message-ID: <47BE7D9E.5010309@qumranet.com> (raw)
In-Reply-To: <47BE2F65.1010903@gmx.at>

Andreas Winkelbauer wrote:
> hi,
>
> I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. 
> The crash was caused by a really _dirty_ hack in a kvm specific part 
> of vga.c (it took me at least an hour to find this amazing piece of 
> code... at least the "HACK ALERT" was a good hint ;-) ).
>
> I've attached the patch. It works for me (tested with windows xp as 
> guest os @ 1680x1050). As always, please test the patch. I'd highly 
> appreciate it if somebody could test it with linux as guest os.
>
> @Arne: Could you please test the patch with your setup? I hope it 
> works this time...
>

The patch doesn't include the change to VGA_RAM_SIZE!  How can this work?

Please send separate patches for the bios and qemu.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-02-22  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22  2:11 [PATCH] fix widescreen resolution issues (v2) Andreas Winkelbauer
2008-02-22  3:39 ` Leslie Mann
2008-02-22  7:45 ` Avi Kivity [this message]
2008-02-22  9:17 ` Arne Brutschy
2008-02-22 12:44   ` Andreas Winkelbauer
2008-02-22 12:55   ` Leslie Mann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BE7D9E.5010309@qumranet.com \
    --to=avi@qumranet.com \
    --cc=andreas.winkelbauer@gmx.at \
    --cc=arne.brutschy@ulb.ac.be \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.