All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	pspencer@fields.utoronto.ca
Subject: Re: [PATCH] e2fsprogs: error checking in blkid/devname.c
Date: Fri, 22 Feb 2008 09:02:56 -0600	[thread overview]
Message-ID: <47BEE420.8030105@redhat.com> (raw)
In-Reply-To: <20080222131622.GK20118@mit.edu>

Theodore Tso wrote:
> This looks good, but I assume that the bug was caused by some race
> condition where if you try to call dm_task_get_info() while some other
> process is creating or removing a snapshot, dm_task_get_info() is
> returning some kind of EAGAIN, or some other "Try again; we're busy"
> error, right?
> 
> If that is the case, can you try to find out what error is being
> returned?  It may be the right thing to do is to check to see if we
> are getting a "resource is locked; try again in a sec" error message,
> and retry the dm_task_get_info(), instead of just returning a failure.

well, dm_task_get_info just returns either 0 or 1; unless there is some
other contextual piece of information to use, I don't know if we can
differentiate between error types.  I'll ask agk...

> Thanks!!
> 
> 						- Ted

  reply	other threads:[~2008-02-22 15:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 22:10 [PATCH] e2fsprogs: error checking in blkid/devname.c Eric Sandeen
2008-02-22 13:16 ` Theodore Tso
2008-02-22 15:02   ` Eric Sandeen [this message]
2008-02-22 15:44     ` Theodore Tso
2008-02-22 16:16       ` Eric Sandeen
2008-02-22 16:33         ` Theodore Tso
2008-02-22 16:52           ` Eric Sandeen
2008-02-22 18:22             ` Theodore Tso
2008-02-22 18:10           ` Philip Spencer
2008-02-22 18:25             ` Theodore Tso
2008-02-22 15:46   ` Philip Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BEE420.8030105@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=pspencer@fields.utoronto.ca \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.