From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] macb: Fix speed setting
Date: Sun, 24 Feb 2008 00:11:48 -0500 [thread overview]
Message-ID: <47C0FC94.6030102@garzik.org> (raw)
In-Reply-To: <20080221.225054.61509660.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by
> conversion to generic PHY layer in kernel 2.6.23.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 81bf005..1d210ed 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device *dev)
>
> if (phydev->duplex)
> reg |= MACB_BIT(FD);
> - if (phydev->speed)
> + if (phydev->speed == SPEED_100)
> reg |= MACB_BIT(SPD);
applied
prev parent reply other threads:[~2008-02-24 5:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 13:50 [PATCH] macb: Fix speed setting Atsushi Nemoto
2008-02-21 14:12 ` Haavard Skinnemoen
2008-02-21 15:04 ` Atsushi Nemoto
2008-02-21 15:07 ` Atsushi Nemoto
2008-02-21 16:39 ` Haavard Skinnemoen
2008-02-21 16:41 ` Haavard Skinnemoen
2008-02-22 9:05 ` Haavard Skinnemoen
2008-02-23 8:03 ` Andrew Morton
2008-02-24 0:50 ` Haavard Skinnemoen
2008-02-24 5:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C0FC94.6030102@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.