From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Don't explicitly set BAR values for VMware VGA Date: Sun, 24 Feb 2008 09:09:18 +0200 Message-ID: <47C1181E.6010304@qumranet.com> References: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Andrzej Zaborowsi , qemu-devel@nongnu.org To: Anthony Liguori Return-path: In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Right now we set explict base addresses for the PCI IO regions in the VMware > VGA device. We don't register the second region at all and instead directly > map the physical memory. > > The problem is, the addresses we're setting in the BAR is not taken into > account in the e820 mapping. > > This patch removes the explicit BARs and registers the second region through > the normal PCI code. > > I've only tested with a Linux guest and the open source VMware VGA driver. > > This patch needs -p2 to apply against the QEMU CVS tree. > > Since it seems like qemu will apply this soon, I'll pick it up via the next merge. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JTAzb-0002Ud-GX for qemu-devel@nongnu.org; Sun, 24 Feb 2008 02:09:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JTAzb-0002UR-1V for qemu-devel@nongnu.org; Sun, 24 Feb 2008 02:09:47 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JTAza-0002UO-Rk for qemu-devel@nongnu.org; Sun, 24 Feb 2008 02:09:46 -0500 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194] helo=il.qumranet.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JTAza-0007At-AC for qemu-devel@nongnu.org; Sun, 24 Feb 2008 02:09:46 -0500 Message-ID: <47C1181E.6010304@qumranet.com> Date: Sun, 24 Feb 2008 09:09:18 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Don't explicitly set BAR values for VMware VGA Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org Anthony Liguori wrote: > Right now we set explict base addresses for the PCI IO regions in the VMware > VGA device. We don't register the second region at all and instead directly > map the physical memory. > > The problem is, the addresses we're setting in the BAR is not taken into > account in the e820 mapping. > > This patch removes the explicit BARs and registers the second region through > the normal PCI code. > > I've only tested with a Linux guest and the open source VMware VGA driver. > > This patch needs -p2 to apply against the QEMU CVS tree. > > Since it seems like qemu will apply this soon, I'll pick it up via the next merge. -- error compiling committee.c: too many arguments to function