From: Eric Sandeen <sandeen@sandeen.net>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] User-space support for bad_features2 patch
Date: Mon, 25 Feb 2008 02:42:11 -0600 [thread overview]
Message-ID: <47C27F63.8070909@sandeen.net> (raw)
In-Reply-To: <op.t611gf1q3jf8g2@pc-bnaujok.melbourne.sgi.com>
Barry Naujok wrote:
> On Sat, 23 Feb 2008 04:41:55 +1100, Eric Sandeen <sandeen@sandeen.net>
> wrote:
...
>> My only thought here is that if you repair it, then use an older kernel
>> w/o the fix, suddenly your fs behavior changes, whereas before you often
>> got lucky, and both userspace & kernelspace swapped the same way, and
>> you found the bits you were looking for out of luck :) (same goes for
>> the recent kernel fix too, I guess)
>
> I believe the kernel code never tried to access "bad_features2" part
> of the superblock, it always did the correct thing (correct me if I'm
> wrong of course :).
I'm fairly sure that it did; both userspace & kernelspace were doing the
same thing, and endian-flipping "too much" ... but I'd have to test
again to be sure.
-Eric
next prev parent reply other threads:[~2008-02-25 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 7:52 [REVIEW] User-space support for bad_features2 patch Barry Naujok
2008-02-22 17:41 ` Eric Sandeen
2008-02-25 0:39 ` Barry Naujok
2008-02-25 8:42 ` Eric Sandeen [this message]
2008-02-25 9:55 ` Jan Derfinak
2008-02-23 5:00 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C27F63.8070909@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.