From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] [3/22] Remove unchecked_isa_dma in advansys.c Date: Mon, 25 Feb 2008 17:54:13 -0500 Message-ID: <47C34715.7040005@garzik.org> References: <200802251235.889863872@firstfloor.org> <20080224233516.0657F1B4183@basil.firstfloor.org> <20080225214746.GA11382@parisc-linux.org> <20080225224035.GB21577@one.firstfloor.org> <20080225225022.GD20273@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:48829 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761411AbYBYWyS (ORCPT ); Mon, 25 Feb 2008 17:54:18 -0500 In-Reply-To: <20080225225022.GD20273@parisc-linux.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Andi Kleen , linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com Matthew Wilcox wrote: > On Mon, Feb 25, 2008 at 11:40:35PM +0100, Andi Kleen wrote: >>> (I must have fixed it somehow because it works on parisc, which is most >>> unforgiving of drivers which do DMA without the DMA API). >> At least on x86 the DMA API cannot do ISA bouncing. > > You're saying that if I set a 24-bit DMA mask, and then do a > pci_alloc_coherent(), x86 might hand me back something that's not > accessible? That would be just broken. Indeed. Jeff