From: Jeff Garzik <jeff@garzik.org>
To: Ke Wei <kewei.mv@gmail.com>
Cc: linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com, qswang@marvell.com,
jfeng@marvell.com, qzhao@marvell.com, lil@marvell.com,
saeed.bishara@gmail.com, kewei@marvell.com
Subject: Re: [PATCH] mvsas: convert from rough draft to working driver
Date: Mon, 25 Feb 2008 18:11:16 -0500 [thread overview]
Message-ID: <47C34B14.4040509@garzik.org> (raw)
In-Reply-To: <20080224114806.GA7908@ubuntu.domain>
Ke Wei wrote:
> On Sat, Feb 23, 2008 at 11:28:50AM -0500, Jeff Garzik wrote:
>> Ke Wei wrote:
>>> Convert rough draft Marvell 6440 driver to a working driver.
>>> Added support for SAS and SATA devices, hotplug, wide port, and expanders.
>>> This patch is based on:
>>> branch 'mvsas' of
>>> git.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
>> Yay! Perfect patch: good tech content, applyable to #mvsas, and the
>> most important part, the driver works :)
>>
>> One minor (though important) detail: may we assume this patch has the
>> same Signed-off-by as previous patches?
>>
>
> Oah, I have no idea how to diff between the previous 5th commit and
> current to use git-format-patch command, so I had to use git-diff to
> create patch. As a result, I format to place my Signed-off-by when
> sending email.
> Jeff, Do you have a good suggestion? Thank you for your help.
That's just a simple mistake, so I wouldn't worry about it. We all
forget such things, every now and then.
If I forget to sign-off on a patch, I usually just reply to my own email
(publicly), providing the Signed-off-by line requested... which is
precisely what you did below :)
> Signed-off-by: Ke Wei <kewei@marvell.com>
Thanks!
Jeff
next prev parent reply other threads:[~2008-02-25 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 13:15 [PATCH] mvsas: convert from rough draft to working driver Ke Wei
2008-02-23 16:28 ` Jeff Garzik
2008-02-24 11:48 ` Ke Wei
2008-02-25 23:11 ` Jeff Garzik [this message]
2008-03-04 18:59 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C34B14.4040509@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jfeng@marvell.com \
--cc=kewei.mv@gmail.com \
--cc=kewei@marvell.com \
--cc=lil@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=qswang@marvell.com \
--cc=qzhao@marvell.com \
--cc=saeed.bishara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.