From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH resend 1/2] Adds ebt_nflog watcher to kernel. Date: Tue, 26 Feb 2008 03:50:29 +0100 Message-ID: <47C37E75.2080803@trash.net> References: <20080205185521.051763000@andrew.endian.com> <20080205185617.732255000@andrew.endian.com> <47BD86EF.7060809@trash.net> <47C34933.8000301@endian.com> <1203981841.2959.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Peter Warasin , netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ebtables-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Bart De Schuymer Return-path: In-Reply-To: <1203981841.2959.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ebtables-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: ebtables-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netfilter-devel.vger.kernel.org Bart De Schuymer wrote: > Op di, 26-02-2008 te 00:03 +0100, schreef Peter Warasin: >> Hi >> >> Patrick McHardy wrote: >>> Peter Warasin wrote: >>> > This patch adds the ebtables nflog watcher to the >>> > kernel >>> This seems mostly fine to me. A few minor comments: >>> If you'll resend the patch based on net-2.6.26 I'll queue it >>> if Bart has no objections. >> I re-based on net-2.6.26 and changed what you mentioned. >> Patch is attached > > It looks fine, I'm just wondering what the flags and the pad in struct > ebt_nflog_info are for... Both have their origin in NFLOG. The flags were intended for something I still want to add, a reliable log mode where packets are dropped when netlink transmission or memory allocation fails. I can't really remember why I added the padding, but in any case it doesn't hurt since the structure size is usually padded to a multiple of 4/8 anyways. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/