From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/15] acpi processor hotplug Date: Wed, 27 Feb 2008 12:55:23 +0200 Message-ID: <47C5419B.3090901@qumranet.com> References: <1204055805-32349-1-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, marcelo@kvack.org, qemu-devel@nongnu.org, chrisw@sous-sol.org To: Glauber Costa Return-path: In-Reply-To: <1204055805-32349-1-git-send-email-gcosta@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Glauber Costa wrote: > Hi, > > I'm resending the series with avi's few comments merged, and a couple > of others on my own: > > * _STA returns 0xF instead of 0x1. According to the specification, it means > that the device, besides present, is also functional, enabled, and a couple > of other cool things. > * gpe_base and proc_base as #defines, not unsigned long > * _EJ method out. It's causing a lot of troubles, and I'm not even sure it > makes sense for processors. We can live without it by now, and if it is needed, > it can be added later. > > Applied all, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUJx5-0002FQ-LT for qemu-devel@nongnu.org; Wed, 27 Feb 2008 05:55:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUJx3-0002DI-RT for qemu-devel@nongnu.org; Wed, 27 Feb 2008 05:55:55 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUJx1-0002Cr-BB for qemu-devel@nongnu.org; Wed, 27 Feb 2008 05:55:52 -0500 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194] helo=il.qumranet.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUJx0-0004wg-KO for qemu-devel@nongnu.org; Wed, 27 Feb 2008 05:55:50 -0500 Message-ID: <47C5419B.3090901@qumranet.com> Date: Wed, 27 Feb 2008 12:55:23 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1204055805-32349-1-git-send-email-gcosta@redhat.com> In-Reply-To: <1204055805-32349-1-git-send-email-gcosta@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [kvm-devel] [PATCH 0/15] acpi processor hotplug Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: kvm-devel@lists.sourceforge.net, marcelo@kvack.org, qemu-devel@nongnu.org, chrisw@sous-sol.org Glauber Costa wrote: > Hi, > > I'm resending the series with avi's few comments merged, and a couple > of others on my own: > > * _STA returns 0xF instead of 0x1. According to the specification, it means > that the device, besides present, is also functional, enabled, and a couple > of other cool things. > * gpe_base and proc_base as #defines, not unsigned long > * _EJ method out. It's causing a lot of troubles, and I'm not even sure it > makes sense for processors. We can live without it by now, and if it is needed, > it can be added later. > > Applied all, thanks. -- error compiling committee.c: too many arguments to function