All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: justin joseph <justin.cok@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: bug in iptables
Date: Wed, 27 Feb 2008 13:07:28 +0100	[thread overview]
Message-ID: <47C55280.6060503@trash.net> (raw)
In-Reply-To: <47BEE08D.9070003@trash.net>

Patrick McHardy wrote:
> Patrick McHardy wrote:
>> justin joseph wrote:
>>
>>> root@hq.enpaq:~# uname -r
>>> 2.6.15-29-386
>>> root@hq.enpaq:~#
>>
>>
>> Thanks, I can reproduce it on current -git. I'll look into it.
> 
> 
> OK actually we've never had a check for this in the kernel.
> Userspace contains some basic checks based on the chainname,
> but this only works for the built-in chains.
> 
> This patch adds the proper checks to the kernel. I'm a bit
> worried though that this might break some rulesets. So
> far we've allowed to create used-defined rules with these
> "invalid" matches, which might even be useful to share
> chains between multiple hooks, even if some matches will
> not match depending on where the jump came from.
> 
> Opinions?


Well, I decided against pushing this patch since there's no
harm in the current behaviour and the risk of breaking things
seems to high.

      reply	other threads:[~2008-02-27 12:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 18:38 bug in iptables justin joseph
2008-02-15  6:50 ` justin joseph
2008-02-19 12:28   ` Patrick McHardy
2008-02-22  7:26     ` justin joseph
2008-02-22 14:08       ` Patrick McHardy
2008-02-22 14:47         ` Patrick McHardy
2008-02-27 12:07           ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C55280.6060503@trash.net \
    --to=kaber@trash.net \
    --cc=justin.cok@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.