From: Patrick McHardy <kaber@trash.net>
To: Wappler Marcel <Marcel.Wappler@bridgeco.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, ebiederman@lnxi.com
Subject: Re: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24
Date: Wed, 27 Feb 2008 13:46:55 +0100 [thread overview]
Message-ID: <47C55BBF.7080501@trash.net> (raw)
In-Reply-To: <83116F0A4FF67A4F97BA0B6E408C48E301C5CDEF@zuerich.BC-Int.NET>
Wappler Marcel wrote:
> --- linux-2.6.24.2/net/ipv4/ipconfig.c 2008-02-21 15:27:47.250890963 +0100
> +++ linux/net/ipv4/ipconfig.c 2008-02-21 15:36:12.686735925 +0100
> @@ -29,6 +29,10 @@
> *
> * Multiple Nameservers in /proc/net/pnp
> * -- Josef Siemes <jsiemes@web.de>, Aug 2002
> + *
> + * Bugfix: Not getting an IP from some DHCP servers: RFC2131 page 36
> + * Table 5 requests DHCPDISCOVER fields ciaddr and siaddr MUST be '0'.
> + * -- marcel.wappler@bridgeco.net
> */
Please don't add changelogs to source files, git keeps track of
them.
> #include <linux/types.h>
> @@ -103,6 +107,7 @@
> - '3' from resolv.h */
>
> #define NONE __constant_htonl(INADDR_NONE)
> +#define ZERO __constant_htonl(((unsigned long int) 0x00000000))
This should probably use INADDR_ANY.
next prev parent reply other threads:[~2008-02-27 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 12:23 [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24 Wappler Marcel
2008-02-27 12:46 ` Patrick McHardy [this message]
2008-02-27 13:11 ` Wappler Marcel
2008-02-27 16:38 ` Stephen Hemminger
2008-02-27 17:25 ` Wappler Marcel
2008-02-27 17:25 ` Wappler Marcel
2008-02-27 19:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C55BBF.7080501@trash.net \
--to=kaber@trash.net \
--cc=Marcel.Wappler@bridgeco.net \
--cc=davem@davemloft.net \
--cc=ebiederman@lnxi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.