From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@suse.de>
Subject: Re: xen-unstable build failure in	tools/blktap/drivers
	for block-qcow2.c
Date: Thu, 28 Feb 2008 13:14:16 +0100
Message-ID: <47C6A598.7010808@suse.de>
References: <C3EC3D06.1D279%Keir.Fraser@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C3EC3D06.1D279%Keir.Fraser@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Srinivas Maturi <srinivas.maturi@oracle.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

> Properly speaking we should check those write() return values anyway. If we
> don't want to deviate from the qemu original sources that much then we could
> special-case CFLAGS to remove -Wno-unused for just that file.

Shouldn't -Wno-unused disable the check rather than enabling it?
Removing it causes even more warnings. Maturi's compiler just seems to
ignore that switch.

I could compile the code with both gcc 4.1.2 and 4.3.0 without any such
problems.

Kevin