All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ned Forrester <nforrester-/d+BM93fTQY@public.gmane.org>
To: Zik Saleeba <zik-fsgeVU6Z5FysTnJN9+BGXg@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Problems with suspend/resume of pxa2xx_spi
Date: Thu, 28 Feb 2008 21:11:13 -0500	[thread overview]
Message-ID: <47C769C1.9030003@whoi.edu> (raw)
In-Reply-To: <33e9dd1c0802281744g48c74670v6b71ced41edf1300-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Zik Saleeba wrote:
> Here's the contents of the registers before suspend:
> 
> SSCR0=00000387

This means: 1/4 clock rate, SSP *enabled*, and 8 bit data.
You don't want to restore the SSP to the running state after resume
because it should not have been running after suspend.  I will comment
more in the next email.

> SSCR1=00000ec0
> SSSR=0000f024
> SSITR=00000000
> SSTO=00000000
> SSPSP=00000000
> 
> And after suspend:
> 
> SSCR0=00000000
> SSCR1=00000000
> SSSR=0000f004
> SSITR=00000000
> SSTO=00000000
> SSPSP=00000000
> 
> I chose to reinitialise the registers to a known correct state rather
> than leave them in their post-suspend state. You may have some better
> ideas about what to do with them.

This state is not the "correct" state to restore.  It has been captured
before the driver is shutdown in preparation for suspend.  If any
restoration is required, it would be to the shutdown state.

-- 
Ned Forrester                                       nforrester-/d+BM93fTQY@public.gmane.org
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-02-29  2:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21  3:32 Problems with suspend/resume of pxa2xx_spi Zik Saleeba
     [not found] ` <33e9dd1c0802201932v6873415bm9202ad478f192b7f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-21  4:31   ` Ned Forrester
     [not found]     ` <47BCFEA4.1090105-/d+BM93fTQY@public.gmane.org>
2008-02-21 19:38       ` David Brownell
2008-02-28 23:02   ` Zik Saleeba
     [not found]     ` <33e9dd1c0802281502x3d045a03pcb6282a781ac4e56-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-29  0:35       ` Zik Saleeba
     [not found]         ` <33e9dd1c0802281635v18bcdd49te38d49e7a24abacf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-29  0:56           ` David Brownell
     [not found]             ` <200802281656.45757.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-02-29  1:02               ` Zik Saleeba
2008-02-29  1:31       ` Ned Forrester
     [not found]         ` <47C76057.30705-/d+BM93fTQY@public.gmane.org>
2008-02-29  1:44           ` Zik Saleeba
     [not found]             ` <33e9dd1c0802281744g48c74670v6b71ced41edf1300-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-29  2:11               ` Ned Forrester [this message]
2008-02-29  4:31       ` Ned Forrester
     [not found]         ` <47C78A98.6010808-/d+BM93fTQY@public.gmane.org>
2008-02-29 23:50           ` Zik Saleeba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C769C1.9030003@whoi.edu \
    --to=nforrester-/d+bm93ftqy@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=zik-fsgeVU6Z5FysTnJN9+BGXg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.