From: Eric Sandeen <sandeen@sandeen.net>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW #3] bad_features2 support in user-space
Date: Thu, 28 Feb 2008 23:44:24 -0600 [thread overview]
Message-ID: <47C79BB8.4010005@sandeen.net> (raw)
In-Reply-To: <op.t69rt3bp3jf8g2@pc-bnaujok.melbourne.sgi.com>
Barry Naujok wrote:
> Ok, xfs_repair will leave bad_features2 in place just in case it is
> being run with an older kernel that expects features2 in the bad
> location. But, it will make sure the correct and bad features2 are
> consistent if bad_features2 in non-zero.
>
> If bad_features2 is zero, it is left alone (eg. new mkfs or new
> kernel with fixes it during mount time).
>
> This seems to be the best solution to the problem.
Will look at details later, but I agree w/ the general direction... I
think maybe the kernel should go this way too? (i.e. kernel maybe
shouldn't be zeroing features2 either... but this is probably more
important for userspace than kernelspace; how often do you revert to an
older kernel...)
-Eric
next prev parent reply other threads:[~2008-02-29 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 4:52 [REVIEW #3] bad_features2 support in user-space Barry Naujok
2008-02-29 5:33 ` Nathan Scott
2008-02-29 5:44 ` Eric Sandeen [this message]
2008-02-29 6:11 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C79BB8.4010005@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.