From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JV2Kv-0005F8-OI for mharc-grub-devel@gnu.org; Fri, 29 Feb 2008 05:19:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV2Kt-0005DZ-Ql for grub-devel@gnu.org; Fri, 29 Feb 2008 05:19:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV2Kt-0005Cg-3p for grub-devel@gnu.org; Fri, 29 Feb 2008 05:19:27 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV2Ks-0005CT-Sr for grub-devel@gnu.org; Fri, 29 Feb 2008 05:19:26 -0500 Received: from mx3.rz.ruhr-uni-bochum.de ([134.147.64.33]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JV2Ks-0004Dc-Lz for grub-devel@gnu.org; Fri, 29 Feb 2008 05:19:26 -0500 X-Queued: (qmail 10924 invoked by uid 271); 29 Feb 2008 08:32:45 -0000 X-Qmailscanner: from 134.147.252.214 by mx3.rz.ruhr-uni-bochum.de (envelope-from , uid 80) with qmail-scanner-2.01 (sophie: 3.05/2.71/4.27. Clear:RC:1(134.147.252.214):. Processed in 0.034318 secs); 29 Feb 2008 08:32:45 -0000 Received: from router.leat.ruhr-uni-bochum.de (134.147.252.214) by mx3.rz.ruhr-uni-bochum.de with SMTP; 29 Feb 2008 08:32:45 -0000 Received: from [134.147.55.45] (frodo.leat.ruhr-uni-bochum.de [134.147.55.45]) by router.leat.ruhr-uni-bochum.de (8.12.2/8.12.2/SuSE Linux 0.6) with ESMTP id m1T8cc1l005722 for ; Fri, 29 Feb 2008 09:38:39 +0100 Message-ID: <47C7C349.6040303@leat.rub.de> Date: Fri, 29 Feb 2008 09:33:13 +0100 From: Fabian Greffrath User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: The development of GRUB 2 References: <47BEDCE2.3000301@leat.rub.de> <47BEEC03.9050902@leat.rub.de> <20080224152237.GB25984@thorin> <47C28F0D.7090703@leat.rub.de> <20080225142009.GJ14597@thorin> <47C66239.9020709@leat.rub.de> <20080228101000.GA350@thorin> <47C68CBD.8020601@leat.rub.de> <20080228104156.GJ350@thorin> <47C69F1D.9090405@leat.rub.de> <20080228170738.GB26926@thorin> In-Reply-To: <20080228170738.GB26926@thorin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 Subject: Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Feb 2008 10:19:28 -0000 Robert Millan schrieb: > Better do this like it's done in other scripts (check grub-install). Not sure > why, I guess it's more portable that way... You mean if [ "x$(FOO)" = "x" ] ... ? > For this one, I think it'd be much better to rework 10_hurd so that code is > shared, rather than duplicating the whole blurb. Yes, we could source out the complete linux/hurd kernel-adding blurbs into an external shell library that is shared with 10_* and 30_os-prober. However, please don't forget these are two different things. 10_* look on / and /boot, while os-prober looks on all *other* partitions. > Do you plan to do that later? Not a concrete plan yet, However, we should first get thinks *working* before we care about cosmetics, IMHO. ;) > Btw, what about *BSD? Does os-prober detect those as "chain" or ... ? I asked myself the same question before. I seems like os-prober does not support any of the BSD flavours, which sounds strange since it even discovers Solaris on i386. Should be a bug against os-prober. > Maybe it's better to echo something here, otherwise it gives the impression > OS FooBar was just detected and properly added. Definitely. I'll add a short warning message. Furthermore, I am going to modify the script to immediately 'exit 0' if it turns out it misses the tools required to update the boot menu (i.e. os-prober, linux-boot-prober, grub-probe (>= 20080228)). These tests are spread all over the script at the moment. Best Regards, Fabian PS: Shouldn't 30_os-prober be an upstream feature of os-prober?!