All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jon Mason <jon@opengridcomputing.com>,
	linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [PATCH] update max_inline_data when creating a qp
Date: Fri, 29 Feb 2008 10:49:52 -0600	[thread overview]
Message-ID: <47C837B0.2040803@opengridcomputing.com> (raw)
In-Reply-To: <1204158583-22858-2-git-send-email-jon@opengridcomputing.com>

Acked-by: Steve Wise <swise@opengridcomputing.com>

Jon Mason wrote:
> mthca modifies the attributes passed in when creating the qp to have
> (amongst other things) the max_inline_data.  While cxgb3 does modify
> the attributes of some of the parameters, it does not modify the
> max_inline_data to be what the adapter supports.  cxgb should conform
> to the same behavior as mthca (as some user space programs are
> expecting this) and return the max_inline_data.
> 
> Signed-off-by: Jon Mason <jon@opengridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index 800ef6d..5f0c9d3 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -818,8 +818,11 @@ static struct ib_qp *iwch_create_qp(struct ib_pd *pd,
>  		kfree(qhp);
>  		return ERR_PTR(-ENOMEM);
>  	}
> +
>  	attrs->cap.max_recv_wr = rqsize - 1;
>  	attrs->cap.max_send_wr = sqsize;
> +	attrs->cap.max_inline_data = T3_MAX_INLINE;
> +
>  	qhp->rhp = rhp;
>  	qhp->attr.pd = php->pdid;
>  	qhp->attr.scq = ((struct iwch_cq *) attrs->send_cq)->cq.cqid;


  parent reply	other threads:[~2008-02-29 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1204158583-22858-1-git-send-email-jon@opengridcomputing.com>
2008-02-29 16:49 ` [PATCH] iwch_create_cq off by one error Steve Wise
2008-03-04 16:29   ` [ofa-general] " Steve Wise
2008-03-04 19:21     ` Roland Dreier
2008-03-09 20:54   ` Roland Dreier
     [not found] ` <1204158583-22858-2-git-send-email-jon@opengridcomputing.com>
2008-02-29 16:49   ` Steve Wise [this message]
2008-02-29 21:53     ` [ofa-general] Re: [PATCH] update max_inline_data when creating a qp Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C837B0.2040803@opengridcomputing.com \
    --to=swise@opengridcomputing.com \
    --cc=general@lists.openfabrics.org \
    --cc=jon@opengridcomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.