All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: Ioan Ionita <opslynx@gmail.com>
Cc: drago01 <drago01@gmail.com>, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Reexport init_mm ?
Date: Fri, 29 Feb 2008 13:01:23 -0500	[thread overview]
Message-ID: <47C84873.4040208@redhat.com> (raw)
In-Reply-To: <df47b87a0802290526h322b5cc6va9621e7329d1ac98@mail.gmail.com>

Ioan Ionita wrote:
> On Thu, Feb 28, 2008 at 9:23 AM, Chris Snook <csnook@redhat.com> wrote:
>> drago01 wrote:
>>  > init_mm is no longer exported in 2.6.25, because there are no in tree
>>  > modules that use it.
>>  > But the closed sources nvidia drivers are using it.
>>  > Is it possible to reexport this symbol to let the driver work with this kernel?
>>
>>  The fact that there are no in-tree modules that use init_mm is rather
>>  compelling evidence that it's not a necessary part of the kernel module
>>  API.  Nvidia needs to fix their code.  If this is a burden, perhaps they
>>  should publish their code under a GPLv2-compatible license so we can
>>  show them how to do it.
> 
> Publish it and get it merged so you'd have no choice but to keep the
> symbol exported in the first place?

High-performance graphics developers are pretty much the last people on 
earth I want to see writing code that calls init_mm.  These people 
patent their bugs, rather than fixing them, when they turn out to make 
things go a little faster and generate "mostly correct" results.  I 
think we have a lot to teach them about kernel driver development, 
including how to get by without init_mm being exported.

	-- Chris


  reply	other threads:[~2008-02-29 18:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27  8:29 Reexport init_mm ? drago01
2008-02-27  9:10 ` Dave Airlie
2008-02-28  7:23 ` Chris Snook
2008-02-29 13:26   ` Ioan Ionita
2008-02-29 18:01     ` Chris Snook [this message]
2008-03-01 11:46       ` Ioan Ionita
2008-03-03 15:54         ` Eragon
2008-03-03 17:07           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C84873.4040208@redhat.com \
    --to=csnook@redhat.com \
    --cc=drago01@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opslynx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.