From: "Andrew G. Morgan" <morgan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] cleanup: correct tabbing of check_kill_permission()
Date: Sat, 01 Mar 2008 14:32:38 -0800 [thread overview]
Message-ID: <47C9D986.3040805@kernel.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew
Here is a small patch to reformat the check_kill_permission() function.
It doesn't change any functionality.
There was something confusing about its tabbing previously, and it also
ran over the 80 column limit.
Cheers
Andrew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFHydmF+bHCR3gb8jsRAmehAKDVnrOMVkHPhZslnhE1tVVXl2x07gCgsAse
LdjzfIwC+dmOqfDGLwnhaOo=
=pQEM
-----END PGP SIGNATURE-----
[-- Attachment #2: 0001-Reformat-check_kill_permission-function-to-make-it.patch --]
[-- Type: text/plain, Size: 1426 bytes --]
From 7dda0a7adb7ab870e01f93b6b066598665e15f7d Mon Sep 17 00:00:00 2001
From: Andrew G. Morgan <morgan@kernel.org>
Date: Mon, 25 Feb 2008 21:49:22 -0800
Subject: [PATCH] Reformat check_kill_permission() function to make it readable.
Signed-off-by: Andrew G. Morgan <morgan@kernel.org>
---
kernel/signal.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 84917fe..77f0439 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -530,17 +530,19 @@ static int check_kill_permission(int sig, struct siginfo *info,
if (!valid_signal(sig))
return error;
- if (info == SEND_SIG_NOINFO || (!is_si_special(info) && SI_FROMUSER(info))) {
- error = audit_signal_info(sig, t); /* Let audit system see the signal */
+ if (info == SEND_SIG_NOINFO
+ || (!is_si_special(info) && SI_FROMUSER(info))) {
+ /* Let audit system see the signal */
+ error = audit_signal_info(sig, t);
if (error)
return error;
error = -EPERM;
- if (((sig != SIGCONT) ||
- (task_session_nr(current) != task_session_nr(t)))
+ if (((sig != SIGCONT)
+ || (task_session_nr(current) != task_session_nr(t)))
&& (current->euid ^ t->suid) && (current->euid ^ t->uid)
&& (current->uid ^ t->suid) && (current->uid ^ t->uid)
&& !capable(CAP_KILL))
- return error;
+ return error;
}
return security_task_kill(t, info, sig, 0);
--
1.5.3.7
next reply other threads:[~2008-03-01 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 22:32 Andrew G. Morgan [this message]
2008-03-02 0:49 ` [PATCH] cleanup: correct tabbing of check_kill_permission() Christoph Hellwig
2008-03-02 5:15 ` Andrew G. Morgan
2008-03-02 8:16 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C9D986.3040805@kernel.org \
--to=morgan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.