From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JVyn4-0005ID-Ml
	for qemu-devel@nongnu.org; Sun, 02 Mar 2008 19:44:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JVyn2-0005I1-8O
	for qemu-devel@nongnu.org; Sun, 02 Mar 2008 19:44:25 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JVyn2-0005Hy-2w
	for qemu-devel@nongnu.org; Sun, 02 Mar 2008 19:44:24 -0500
Received: from pop-tawny.atl.sa.earthlink.net ([207.69.195.67])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <reif@earthlink.net>) id 1JVyn1-00078f-Nm
	for qemu-devel@nongnu.org; Sun, 02 Mar 2008 19:44:23 -0500
Received: from user-142h2k8.cable.mindspring.com ([72.40.138.136]
	helo=earthlink.net)
	by pop-tawny.atl.sa.earthlink.net with esmtp (Exim 3.36 #1)
	id 1JVyn1-0002ni-00
	for qemu-devel@nongnu.org; Sun, 02 Mar 2008 19:44:23 -0500
Message-ID: <47CB49E2.2040908@earthlink.net>
Date: Sun, 02 Mar 2008 19:44:18 -0500
From: Robert Reif <reif@earthlink.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------090408060309070609070204"
Subject: [Qemu-devel] [PATCH] hw/slavio_timer.c remove unneeded
	qemu_irq_lower
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------090408060309070609070204
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Remove unneeded qemu_irq_lower because user mode timers don't support 
IRQs and the IRQ is lowered when switching to user mode.

--------------090408060309070609070204
Content-Type: text/plain;
 name="timer.diff.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="timer.diff.txt"

diff -p -u -r1.30 slavio_timer.c
--- hw/slavio_timer.c	26 Jan 2008 09:13:46 -0000	1.30
+++ hw/slavio_timer.c	3 Mar 2008 00:35:28 -0000
@@ -192,7 +192,6 @@ static void slavio_timer_mem_writel(void
             uint64_t count;
 
             // set user counter MSW, reset counter
-            qemu_irq_lower(s->irq);
             s->limit = TIMER_MAX_COUNT64;
             s->counthigh = val & (TIMER_MAX_COUNT64 >> 32);
             s->reached = 0;
@@ -218,7 +217,6 @@ static void slavio_timer_mem_writel(void
             uint64_t count;
 
             // set user counter LSW, reset counter
-            qemu_irq_lower(s->irq);
             s->limit = TIMER_MAX_COUNT64;
             s->count = val & TIMER_MAX_COUNT64;
             s->reached = 0;

--------------090408060309070609070204--