From: Patrick McHardy <kaber@trash.net>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix computation of allocated size for netlink skb.
Date: Tue, 04 Mar 2008 15:57:23 +0100 [thread overview]
Message-ID: <47CD6353.8040208@trash.net> (raw)
In-Reply-To: <1204623963-10600-2-git-send-email-eric@inl.fr>
Eric Leblond wrote:
> Size of the netlink skb was wrongly computed because the formula was using
> NLMSG_ALIGN instead of NLMSG_SPACE. NLMSG_ALIGN does not add the room for
> netlink header as NLMSG_SPACE does. This was causing a failure of message
> building in some cases.
>
> On my test system, all messages for packets in range [8*k+41, 8*k+48] where k
> is an integer were invalid and the corresponding packets were dropped.
Applied, thanks.
next prev parent reply other threads:[~2008-03-04 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 9:46 [PATCH 0/2] NFLOG and NFQUEUE fixes Eric Leblond
2008-03-04 9:46 ` [PATCH 1/2] Fix computation of allocated size for netlink skb Eric Leblond
2008-03-04 14:57 ` Patrick McHardy [this message]
2008-03-04 9:46 ` [PATCH 2/2] Fix computation of netlink skb size Eric Leblond
2008-03-04 14:58 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CD6353.8040208@trash.net \
--to=kaber@trash.net \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.