All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <gcosta@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm-devel@lists.sourceforge.net, chrisw@sous-sol.org, avi@qumranet.com
Subject: Re: [PATCH 0/8] RFC: vcpu pinning at qemu start
Date: Tue, 04 Mar 2008 16:59:04 -0300	[thread overview]
Message-ID: <47CDAA08.3030006@redhat.com> (raw)
In-Reply-To: <47CDA2D8.7060709@codemonkey.ws>

Anthony Liguori wrote:
> Glauber Costa wrote:
>> My main interest is in management tools being able to specify pinning
>> set ups at VM creation time.
>>
>> As I said, it can be done through tools like taskset, but then you'd 
>> have to know:
>>  * when are the threads created
>>  * which thread ids corresponds to each cpu
>>
>> And of course, for an amount of time, the threads will be running in a 
>> "wrong" cpu, which may affect workloads running there. (which is a 
>> case cpu pinning usually tries to address)
> 
> A management tool can start QEMU with -S to prevent any CPUs from 
> running, query the VCPU=>thread id relationship (modifying info cpus 
> would be a good thing to do for this), taskset, and then run 'cont' in 
> the monitor if they desperately need this functionality.  However, I 
> don't think the vast majority of people need this particular functionality.

No, it can't. Because at the time qemu starts, no vcpu -> thread id 
relationship exists at all. And we don't know when it will.

It would be a different story if there were some kind of api that could
warn qemu
 > My feeling is that adding an interface to do this in QEMU encourages
 > people to not use the existing Linux tools for this or worse yet, to
 > think they can do a better job than Linux.

I agree with you that we should stick with linux tools, and that's why I 
didn't provide any kind of runtime setting via qemu monitor to do this 
(with the infrastructure, it would be trivial). taskset will do.

> The whole reason this exists 
> in Xen is that Xen's schedulers were incapable of doing CPU migration 
> historically (which is no longer true since the credit scheduler).  It 
> was necessary to specify pinning upon creation or you were stuck with 
> round-robin placement.  So libvirt has APIs for this because they were 
> part of the Xen API because it was needed to get reasonable performance 
> at some point in time on Xen.  I don't think this behavior is useful for 
> KVM though.  Just because Xen does it doesn't imply that we should do it.
No, not just because xen does.

I do however feel it useful, since starting a vm and then let it run 
unchanged is definitely an useful use case. And as I tried to show you,
I can't see a good way to do that for pinning.

> Regards,
> 
> Anthony Liguori
> 
>>
>>
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-03-04 19:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 16:21 [PATCH 0/8] RFC: vcpu pinning at qemu start Glauber Costa
2008-03-04 16:21 ` [PATCH 1/8] add thread id to vcpu structure Glauber Costa
2008-03-04 16:21   ` [PATCH 2/8] provide a gettid function Glauber Costa
2008-03-04 16:21     ` [PATCH 3/8] get thread id at thread's creation Glauber Costa
2008-03-04 16:21       ` [PATCH 4/8] store and set cpu affinities Glauber Costa
2008-03-04 16:21         ` [PATCH 5/8] initialize affinities Glauber Costa
2008-03-04 16:21           ` [PATCH 6/8] stabilish default affinity for newly created cpus Glauber Costa
2008-03-04 16:22             ` [PATCH 7/8] process a cpu affinity mask Glauber Costa
2008-03-04 16:22               ` [PATCH 8/8] provide -cpu-map option Glauber Costa
2008-03-04 17:26 ` [PATCH 0/8] RFC: vcpu pinning at qemu start Joerg Roedel
2008-03-04 18:11   ` Glauber Costa
2008-03-04 18:19     ` Joerg Roedel
2008-03-04 17:42 ` Anthony Liguori
2008-03-04 18:10   ` Glauber Costa
2008-03-04 19:28     ` Anthony Liguori
2008-03-04 19:42       ` Daniel P. Berrange
2008-03-04 20:00         ` Glauber Costa
2008-03-04 19:59       ` Glauber Costa [this message]
2008-03-05  3:43         ` Anthony Liguori
2008-03-05  6:44           ` Avi Kivity
2008-03-05 13:10           ` Glauber Costa
2008-03-05  5:35       ` Avi Kivity
2008-03-05 14:29         ` Anthony Liguori
2008-03-05  5:28 ` Avi Kivity
2008-03-05 13:13   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CDAA08.3030006@redhat.com \
    --to=gcosta@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=chrisw@sous-sol.org \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.