From: Eric Sandeen <sandeen@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, jbacik@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] add a jbd option to force an unclean journal state
Date: Tue, 04 Mar 2008 20:46:14 -0600 [thread overview]
Message-ID: <47CE0976.70304@redhat.com> (raw)
In-Reply-To: <20080304155801.6f48bf08.akpm@linux-foundation.org>
Andrew Morton wrote:
> So it's 100% scriptable and can be left running overnight, etc. It found
> quite a few problems with ext3/jbd recovery which I doubt could be found by
> other means. This was 6-7 years ago and I'd expect that new recovery bugs
> have crept in since then which it can expose.
>
> I think we should implement this in a formal, mergeable fashion, as there
> are numerous filesystems which could and should use this sort of testing
> infrastructure.
FWIW, xfs has something vaguely similar, the XFS_IOC_GOINGDOWN ioctl,
which invokes xfs_fs_goingdown, which takes a few flags:
/*
* Flags for going down operation
*/
#define XFS_FSOP_GOING_FLAGS_DEFAULT 0x0 /* going down */
#define XFS_FSOP_GOING_FLAGS_LOGFLUSH 0x1 /* flush log but
not data */
#define XFS_FSOP_GOING_FLAGS_NOLOGFLUSH 0x2 /* don't flush
log nor data */
but ultimately calls xfs_force_shutdown, which is sort of rougly similar
to ext3_abort....
The xfs qa tests make use of this ioctl.
-Eric
next prev parent reply other threads:[~2008-03-05 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 18:39 [RFC PATCH 1/1] add a jbd option to force an unclean journal state Josef Bacik
2008-03-04 19:01 ` Jan Kara
2008-03-04 23:58 ` Andrew Morton
2008-03-05 2:46 ` Eric Sandeen [this message]
2008-03-05 7:34 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CE0976.70304@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.