From: Avi Kivity <avi@qumranet.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: kvm-devel@lists.sourceforge.net,
Zdenek Kabelac <zdenek.kabelac@gmail.com>
Subject: Re: loop in copy_user_generic_string
Date: Wed, 05 Mar 2008 08:50:41 +0200 [thread overview]
Message-ID: <47CE42C1.5040701@qumranet.com> (raw)
In-Reply-To: <p73lk4y5qpc.fsf@bingen.suse.de>
Andi Kleen wrote:
> Avi Kivity <avi@qumranet.com> writes:
>
>> Most likely movs emulation is broken for long counts. Please post a
>> disassembly of copy_user_generic_string to make sure we're looking at
>> the same code.
>>
>
> Be careful -- this code is patched at runtime and what you
> see in the vmlinux is not necessarily the same that is executed
>
>
If the disassembled instruction isn't marked as an alternative in the
source, then it can't be patched, right?
> Incidentially that might cause problems.
Specific to kvm? how?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-05 6:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 16:02 loop in copy_user_generic_string Zdenek Kabelac
2008-03-04 16:07 ` Avi Kivity
2008-03-04 16:39 ` Zdenek Kabelac
2008-03-04 17:10 ` Avi Kivity
2008-03-04 17:44 ` Andi Kleen
2008-03-05 6:50 ` Avi Kivity [this message]
2008-03-05 8:52 ` Zdenek Kabelac
2008-03-07 19:32 ` Zdenek Kabelac
2008-03-09 22:13 ` Zdenek Kabelac
2008-03-11 22:19 ` Zdenek Kabelac
2008-03-12 12:50 ` Zdenek Kabelac
2008-03-12 14:40 ` Andi Kleen
2008-03-12 15:49 ` Zdenek Kabelac
2008-03-12 16:08 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CE42C1.5040701@qumranet.com \
--to=avi@qumranet.com \
--cc=andi@firstfloor.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.