From: Gilles Carry <Gilles.Carry@bull.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sripathi Kodi <sripathik@in.ibm.com>,
linux-rt-users@vger.kernel.org, mingo@elte.hu
Subject: Re: BUG on 2.6.24.3-rt3.
Date: Wed, 05 Mar 2008 09:05:50 +0100 [thread overview]
Message-ID: <47CE545E.9060406@bull.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0803041335560.9858@gandalf.stny.rr.com>
Hi,
I had this bug also when testing ltp's hrtimer-prio.c.
So far I could not reproduce it but still I applied your patch.
I'll let you know if I find something useful.
Gilles.
Steven Rostedt wrote:
>Sripathi,
>
>Thanks for reporting this.
>
>On Tue, 4 Mar 2008, Sripathi Kodi wrote:
>
>
>>I can recreate the problem easily and can also get a kdump. Please let
>>me know if any other information will help in analyzing this.
>>
>>
>
>Could you try this patch and let me know if it fixes your problem.
>
>-- Steve
>
>Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
>---
> kernel/sched_rt.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>Index: linux-2.6.24.3-rt3/kernel/sched_rt.c
>===================================================================
>--- linux-2.6.24.3-rt3.orig/kernel/sched_rt.c 2008-03-04 13:49:53.000000000 -0500
>+++ linux-2.6.24.3-rt3/kernel/sched_rt.c 2008-03-04 13:51:27.000000000 -0500
>@@ -840,9 +840,11 @@ static void prio_changed_rt(struct rq *r
> pull_rt_task(rq);
> /*
> * If there's a higher priority task waiting to run
>- * then reschedule.
>+ * then reschedule. Note, the above pull_rt_task
>+ * can release the rq lock and p could migrate.
>+ * Only reschedule if p is still on the same runqueue.
> */
>- if (p->prio > rq->rt.highest_prio)
>+ if (p->prio > rq->rt.highest_prio && task_rq(p) == rq)
> resched_task(p);
> #else
> /* For UP simply resched on drop of prio */
>--
>To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Gilles.Carry
Linux Project team
mailto: gilles.carry@bull.net
Phone: +33 (0)4 76 29 74 27
Addr.: BULL S.A. 1 rue de Provence, B.P. 208 38432 Echirolles Cedex
http://www.bull.com
http://www.bullopensource.org/
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2008-03-05 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 17:19 BUG on 2.6.24.3-rt3 Sripathi Kodi
2008-03-04 18:54 ` Steven Rostedt
2008-03-05 8:05 ` Gilles Carry [this message]
2008-03-05 8:44 ` Sripathi Kodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CE545E.9060406@bull.net \
--to=gilles.carry@bull.net \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sripathik@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.