All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Claudio Lanconelli <lanconelli.claudio@eptar.com>
Cc: netdev@vger.kernel.org, David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH] net/enc28j60: low power mode
Date: Wed, 05 Mar 2008 06:13:47 -0500	[thread overview]
Message-ID: <47CE806B.9010102@pobox.com> (raw)
In-Reply-To: <47B415D3.6020200@eptar.com>

Claudio Lanconelli wrote:
> Keep enc28j60 chips in low-power mode when they're not in use.
> At typically 120 mA, these chips run hot even when idle; this
> low power mode cuts that power usage by a factor of around 100.
> 
> This version provides a generic routine to poll a register until
> its masked value equals some value ... e.g. bit set or cleared.
> It's basically what the previous wait_phy_ready() did, but this
> version is generalized to support the handshaking needed to
> enter and exit low power mode.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: Claudio Lanconelli <lanconelli.claudio@eptar.com>

It's a bit silly to create a variable just to store the result of 
msecs_to_jiffies(constant)



  reply	other threads:[~2008-03-05 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 10:20 [PATCH] net/enc28j60: low power mode Claudio Lanconelli
2008-03-05 11:13 ` Jeff Garzik [this message]
2008-03-05 23:31   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CE806B.9010102@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=david-b@pacbell.net \
    --cc=lanconelli.claudio@eptar.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.