All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@domain.hid>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] Shared IRQ issue with Xeno Peak PCI CAN driver
Date: Thu, 06 Mar 2008 12:35:28 +0100	[thread overview]
Message-ID: <47CFD700.5070001@domain.hid> (raw)
In-Reply-To: <47CEA5FD.4080202@domain.hid>

Jan Kiszka wrote:
> Klaas Gadeyne wrote:
>> --- rtcan_sja1000.c     (revision 3533)
>> +++ rtcan_sja1000.c     (working copy)
>> @@ -765,7 +765,7 @@
>>       if (ret) {
>>          printk(KERN_ERR "ERROR %d: IRQ %d is %s!\n",
>>                 ret, chip->irq_num, ret == -EBUSY ?
>> -              "busy, check shared interrupt support" : "invalid");
>> +              "busy. If you have a card with > 1 channel, check if CONFIG_XENO_OPT_SHIRQ* is set" : "invalid");
>>          return ret;
>>       }
>>
>> Not kernel coding style, I know :-)
> 
> #ifndef CONFIG_XENO_OPT_SHIRQ
> 	printk("Enable CONFIG_XENO_OPT_SHIRQ")
> ?

No. In the past the config name changed with 2.4 and that was the main
reason to remove it from the driver. I'm going to update the description
and error messages as suggested by Klaas, but avoiding the config name.

Thanks,

Wolfgang.


  reply	other threads:[~2008-03-06 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 17:12 [Xenomai-help] Shared IRQ issue with Xeno Peak PCI CAN driver Klaas Gadeyne
2008-03-05 11:34 ` Wolfgang Grandegger
2008-03-05 12:41   ` Klaas Gadeyne
2008-03-05 13:05     ` Wolfgang Grandegger
2008-03-05 13:40       ` Klaas Gadeyne
2008-03-05 13:54         ` Jan Kiszka
2008-03-06 11:35           ` Wolfgang Grandegger [this message]
2008-03-07 12:54             ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CFD700.5070001@domain.hid \
    --to=wg@domain.hid \
    --cc=jan.kiszka@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.