From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid casts
Date: Fri, 07 Mar 2008 00:01:41 +0100 [thread overview]
Message-ID: <47D077D5.50306@cosmosbay.com> (raw)
In-Reply-To: <20080305.183539.76566188.davem@davemloft.net>
David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Thu, 06 Mar 2008 00:30:02 +0100
>
>> [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid
>> casts
>>
>> (Anonymous) unions can help us to avoid ugly casts.
>>
>> A common cast it the (struct rtable *)skb->dst one.
>>
>> Defining an union like :
>> union {
>> struct dst_entry *dst;
>> struct rtable *rtable;
>> };
>> permits to use dkb->rtable in place.
>>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>>
>
> Applied with some minor changelog tidy and typo fixups.
>
> Please make your changelog entry header lines smaller in
> the future. People scan them in shortlog output and it's
> less readable if it's wider than standard terminal widths.
Thanks David, I'll try to shorten headers :)
prev parent reply other threads:[~2008-03-06 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 7:15 [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid casts Eric Dumazet
2008-03-04 7:23 ` David Miller
2008-03-04 7:36 ` Eric Dumazet
2008-03-04 7:46 ` David Miller
2008-03-05 23:30 ` Eric Dumazet
2008-03-06 2:35 ` David Miller
2008-03-06 23:01 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D077D5.50306@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.