From: Randy Dunlap <randy.dunlap@oracle.com>
To: Pierre Peiffer <peifferp@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.25-rc3-mm1] IPC: fix a kernel-doc warning
Date: Fri, 07 Mar 2008 13:01:41 -0800 [thread overview]
Message-ID: <47D1AD35.6010102@oracle.com> (raw)
In-Reply-To: <878847400803071236w47178fa4r79f50d537b383843@mail.gmail.com>
Pierre Peiffer wrote:
> Hi,
>
> This patch fixes this warning produced by kernel-doc (thanks Randy Dunlap):
>
> Warning(linux-2.6.25-rc3-mm1//ipc/util.c:845):
> No description found for parameter 'extrat_perm'
>
> It is due to an inconsistency in a variable name between the C-code and
> the associated comment.
>
> Signed-off-by: Pierre Peiffer <peifferp@gmail.com>
Thanks, looks good.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> ipc/util.c | 4 ++--
> ipc/util.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Index: b/ipc/util.c
> ===================================================================
> --- a/ipc/util.c
> +++ b/ipc/util.c
> @@ -841,7 +841,7 @@
> * or an err-code without any lock held otherwise.
> */
> struct kern_ipc_perm *ipcctl_pre_down(struct ipc_ids *ids, int id, int cmd,
> - struct ipc64_perm *perm, int extrat_perm)
> + struct ipc64_perm *perm, int extra_perm)
> {
> struct kern_ipc_perm *ipcp;
> int err;
> @@ -858,7 +858,7 @@
> goto out_unlock;
>
> if (cmd == IPC_SET) {
> - err = audit_ipc_set_perm(extrat_perm, perm->uid,
> + err = audit_ipc_set_perm(extra_perm, perm->uid,
> perm->gid, perm->mode);
> if (err)
> goto out_unlock;
> Index: b/ipc/util.h
> ===================================================================
> --- a/ipc/util.h
> +++ b/ipc/util.h
> @@ -114,7 +114,7 @@
> void ipc64_perm_to_ipc_perm(struct ipc64_perm *in, struct ipc_perm *out);
> void ipc_update_perm(struct ipc64_perm *in, struct kern_ipc_perm *out);
> struct kern_ipc_perm *ipcctl_pre_down(struct ipc_ids *ids, int id, int cmd,
> - struct ipc64_perm *perm, int extrat_perm);
> + struct ipc64_perm *perm, int extra_perm);
>
> #if defined(__ia64__) || defined(__x86_64__) || defined(__hppa__) ||
> defined(__XTENSA__)
> /* On IA-64, we always use the "64-bit version" of the IPC structures. */
>
--
~Randy
prev parent reply other threads:[~2008-03-07 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 20:36 [PATCH 2.6.25-rc3-mm1] IPC: fix a kernel-doc warning Pierre Peiffer
2008-03-07 21:01 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D1AD35.6010102@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peifferp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.