From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2/7] Convert open coded reference in libata to q->bounce_gfp to blk_kmalloc
Date: Fri, 07 Mar 2008 16:06:44 -0500 [thread overview]
Message-ID: <47D1AE64.2000405@pobox.com> (raw)
In-Reply-To: <20080307091322.EF4311B419C@basil.firstfloor.org>
Andi Kleen wrote:
> Only difference in behaviour is that GFP_NOIO is not passed here now,
> but I think that is ok in this case because this is not in a write out path.
>
> Cc: jgarzik@pobox.com
>
> Signed-off-by: Andi Kleen <ak@suse.de>
>
> ---
> drivers/ata/libata-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/ata/libata-scsi.c
> ===================================================================
> --- linux.orig/drivers/ata/libata-scsi.c
> +++ linux/drivers/ata/libata-scsi.c
> @@ -868,7 +868,7 @@ static int ata_scsi_dev_config(struct sc
> blk_queue_dma_pad(sdev->request_queue, ATA_DMA_PAD_SZ - 1);
>
> /* configure draining */
> - buf = kmalloc(ATAPI_MAX_DRAIN, q->bounce_gfp | GFP_KERNEL);
> + buf = blk_kmalloc(q, ATAPI_MAX_DRAIN, GFP_KERNEL);
I think that's a fair assessment... ACK
next prev parent reply other threads:[~2008-03-07 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 9:13 [PATCH] [0/7] Block layer rework for mask allocator Andi Kleen
2008-03-07 9:13 ` [PATCH] [1/7] Convert a few direct bounce_gfp users over to the blk_* wrappers Andi Kleen
2008-03-07 9:13 ` [PATCH] [2/7] Convert open coded reference in libata to q->bounce_gfp to blk_kmalloc Andi Kleen
2008-03-07 21:06 ` Jeff Garzik [this message]
2008-03-07 9:13 ` [PATCH] [3/7] Add mempool support for page allocation through the mask allocator Andi Kleen
2008-03-07 9:13 ` [PATCH] [4/7] Add blk_q_mask Andi Kleen
2008-03-07 9:13 ` [PATCH] [5/7] Convert the blk allocator functions over to the mask allocator Andi Kleen
2008-03-07 9:13 ` [PATCH] [6/7] Remove bounce_gfp Andi Kleen
2008-03-07 9:13 ` [PATCH] [7/7] Allow swiotlb to move block data bouncing to the block layer Andi Kleen
2008-03-08 12:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D1AE64.2000405@pobox.com \
--to=jgarzik@pobox.com \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.