From: Roel Kluin <12o3l@tiscali.nl>
To: jschlst@samba.org, p_gortmaker@yahoo.com
Cc: netdev@vger.kernel.org
Subject: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?
Date: Sun, 09 Mar 2008 22:43:43 +0100 [thread overview]
Message-ID: <47D45A0F.1060102@tiscali.nl> (raw)
drivers/net/tokenring/smctr.c:3416
tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) || IBM_PASS_SOURCE_ADDR);
shouldn't this be a bit-wise or?
from drivers/net/tokenring/smctr.h:50:
#define IBM_PASS_SOURCE_ADDR 0x01
next reply other threads:[~2008-03-09 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 21:43 Roel Kluin [this message]
2008-03-10 0:09 ` drivers/net/tokenring/smctr.c: logical-bitwise or confusion? Paul Gortmaker
2008-03-10 1:16 ` Roel Kluin
2008-03-10 1:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D45A0F.1060102@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=jschlst@samba.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.