All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
To: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Cc: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
	xen-devel@lists.xensource.com, "Zhai,
	Edwin" <edwin.zhai@intel.com>
Subject: Re: [PATCH] PV Passthrough PCI Device Hotplug Support(Tools Part)
Date: Mon, 10 Mar 2008 11:26:08 +0900	[thread overview]
Message-ID: <47D49C40.7010404@ab.jp.nec.com> (raw)
In-Reply-To: <C0C882532392D6kanno.masaki@jp.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Masaki Kanno wrote:
> Hi Iwamatsu,
> 
>  def xm_pci_detach(args):
> -    arg_check(args, 'pci-detach', 2)
> -    dom = args[0]
> -    dev = args[1]
> -    server.xend.domain.destroyDevice(dom, 'dpci', dev)
> +    arg_check(args, 'pci-detach', 2, 2)  <----------------- here!!
> +    (dom, pci) = parse_pci_configuration(args, 'Closing')
> +    server.xend.domain.device_configure(dom, pci)
> +
> 
> The last "2" is not necessary. 

All right.
The revised patch is attached.

-- Yosuke


[-- Attachment #2: pv_pcihp_tools_merge-r1.patch --]
[-- Type: all/allfiles, Size: 31591 bytes --]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

  reply	other threads:[~2008-03-10  2:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 11:01 [PATCH 1/3][RFC] PV Passthrough PCI Device Hotplug Support (Tools Part) Yosuke Iwamatsu
2008-02-22 10:04 ` Keir Fraser
2008-02-22 10:19   ` Yosuke Iwamatsu
2008-03-10  1:19     ` [PATCH] " Yosuke Iwamatsu
2008-03-10  2:04       ` [PATCH] PV Passthrough PCI Device Hotplug Support(Tools Part) Masaki Kanno
2008-03-10  2:26         ` Yosuke Iwamatsu [this message]
2008-03-10  7:17       ` [PATCH] PV Passthrough PCI Device Hotplug Support (Tools Part) Zhai, Edwin
2008-03-10 11:22         ` Yosuke Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D49C40.7010404@ab.jp.nec.com \
    --to=y-iwamatsu@ab.jp.nec.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=edwin.zhai@intel.com \
    --cc=kanno.masaki@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.