From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
Subject: Re: [PATCH] PV Passthrough PCI Device Hotplug Support
	(Tools Part)
Date: Mon, 10 Mar 2008 20:22:54 +0900
Message-ID: <47D51A0E.3090108@ab.jp.nec.com>
References: <C3E44EB2.1440F%Keir.Fraser@cl.cam.ac.uk>	<47BEA1AC.40707@ab.jp.nec.com>
	<47D48C8E.7060206@ab.jp.nec.com>
	<20080310071700.GM15578@edwin-srv.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080310071700.GM15578@edwin-srv.sh.intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Zhai, Edwin wrote:
> Yosuke,
> 
> Thanks for you work.
> I have tested your patch works on HVM VT-d side.

I'm relieved to hear that. Thank you.

> 
> One suggestion is error handling for user input. e.g. following input error 
> should be caught by xm:
> 
> [root@vt-gang32 ~]# xm pci-attach EdwinHVMDomainVtd2 0:2.0.0    (should be 
> 0:2:0.0)
> 
> Error: pci: failed to locate device and parse it's resources - [Errno 2] No such 
> file or directory: '/sys/bus/pci/devices/0000:00:02.0/driver'
> Usage: xm pci-attach <Domain> <domain:bus:slot.func> [virtual slot]

Okay.
The small patch below should fix the issue.
(applied after the previous patch)

Thanks,
   Yosuke Iwamatsu

---------

xm: Fix parsing pci device name.

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>

diff -r 9233270dfe6a tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py	Mon Mar 10 17:58:25 2008 +0900
+++ b/tools/python/xen/xm/main.py	Mon Mar 10 20:26:49 2008 +0900
@@ -2240,7 +2240,7 @@ def parse_pci_configuration(args, state)
      pci_match = re.match(r"((?P<domain>[0-9a-fA-F]{1,4})[:,])?" + \
              r"(?P<bus>[0-9a-fA-F]{1,2})[:,]" + \
              r"(?P<slot>[0-9a-fA-F]{1,2})[.,]" + \
-            r"(?P<func>[0-9a-fA-F])", pci_dev_str)
+            r"(?P<func>[0-7])$", pci_dev_str)
      if pci_match == None:
          raise OptionError("Invalid argument: %s %s" % (pci_dev_str,vslt))
      pci_dev_info = pci_match.groupdict('0')