All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Lalancette <clalance@redhat.com>
To: xen-devel <xen-devel@lists.xensource.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH]: Add "Warning" to the time went backwards messages
Date: Mon, 10 Mar 2008 10:44:07 -0400	[thread overview]
Message-ID: <47D54937.90304@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

All,
    Attached is a patch from Prarit Bhargava, who is not subscribed to the list
(but CC'ed).  His description follows:

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

[-- Attachment #2: 436755.patch --]
[-- Type: text/x-patch, Size: 1072 bytes --]

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/arch/i386/kernel/time-xen.c b/arch/i386/kernel/time-xen.c
index 532ad14..d4c8dfc 100644
--- a/arch/i386/kernel/time-xen.c
+++ b/arch/i386/kernel/time-xen.c
@@ -665,8 +665,8 @@ irqreturn_t timer_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 	if ((unlikely(delta < -(s64)permitted_clock_jitter) ||
 	     unlikely(delta_cpu < -(s64)permitted_clock_jitter))
 	    && printk_ratelimit()) {
-		printk("Timer ISR/%d: Time went backwards: "
-		       "delta=%lld delta_cpu=%lld shadow=%lld "
+		printk(KERN_WARNING "Warning Timer ISR/%d: Time went "
+		       "backwards: delta=%lld delta_cpu=%lld shadow=%lld "
 		       "off=%lld processed=%lld cpu_processed=%lld\n",
 		       cpu, delta, delta_cpu, shadow->system_timestamp,
 		       (s64)get_nsec_offset(shadow),

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2008-03-10 14:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D54937.90304@redhat.com \
    --to=clalance@redhat.com \
    --cc=prarit@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.