All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH]: Add "Warning" to the time went backwards messages
@ 2008-03-10 14:44 Chris Lalancette
  0 siblings, 0 replies; only message in thread
From: Chris Lalancette @ 2008-03-10 14:44 UTC (permalink / raw)
  To: xen-devel; +Cc: Prarit Bhargava

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

All,
    Attached is a patch from Prarit Bhargava, who is not subscribed to the list
(but CC'ed).  His description follows:

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

[-- Attachment #2: 436755.patch --]
[-- Type: text/x-patch, Size: 1072 bytes --]

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/arch/i386/kernel/time-xen.c b/arch/i386/kernel/time-xen.c
index 532ad14..d4c8dfc 100644
--- a/arch/i386/kernel/time-xen.c
+++ b/arch/i386/kernel/time-xen.c
@@ -665,8 +665,8 @@ irqreturn_t timer_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 	if ((unlikely(delta < -(s64)permitted_clock_jitter) ||
 	     unlikely(delta_cpu < -(s64)permitted_clock_jitter))
 	    && printk_ratelimit()) {
-		printk("Timer ISR/%d: Time went backwards: "
-		       "delta=%lld delta_cpu=%lld shadow=%lld "
+		printk(KERN_WARNING "Warning Timer ISR/%d: Time went "
+		       "backwards: delta=%lld delta_cpu=%lld shadow=%lld "
 		       "off=%lld processed=%lld cpu_processed=%lld\n",
 		       cpu, delta, delta_cpu, shadow->system_timestamp,
 		       (s64)get_nsec_offset(shadow),

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-10 14:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-10 14:44 [PATCH]: Add "Warning" to the time went backwards messages Chris Lalancette

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.