From: Ben Guthro <bguthro@virtualiron.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Schedule shutdown fix
Date: Mon, 10 Mar 2008 15:14:45 -0400 [thread overview]
Message-ID: <47D588A5.4040200@virtualiron.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
domain_shutdown() needs to call raise_softirq(SCHEDULE_SOFTIRQ).
This forces the current vcpu to be rescheduled and paused.
Without this, during live migrate, if another vcpu has defer_shutdown==1
then the current vcpu can return from domain_shutdown(),
do a vmenter, and continue running guest code, "resume" code that
should only be running on the receiving node!
Signed-off-by: Robert Phillips <rphillips@virtualiron.com>
Signed-off-by: Ben Guthro <bguthro@virtualiron.com>
[-- Attachment #2: xen-shutdown-schedule.patch --]
[-- Type: text/x-patch, Size: 310 bytes --]
diff -r 4674efa621d4 xen/common/domain.c
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -415,6 +415,7 @@ void domain_shutdown(struct domain *d, u
__domain_finalise_shutdown(d);
spin_unlock(&d->shutdown_lock);
+ raise_softirq(SCHEDULE_SOFTIRQ);
}
void domain_resume(struct domain *d)
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2008-03-10 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 19:14 Ben Guthro [this message]
2008-03-10 19:31 ` [PATCH] Schedule shutdown fix Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D588A5.4040200@virtualiron.com \
--to=bguthro@virtualiron.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.