From: Paul Fulghum <paulkf@microgate.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] synclink drivers bool conversion
Date: Mon, 10 Mar 2008 15:26:43 -0600 [thread overview]
Message-ID: <47D5A793.9070105@microgate.com> (raw)
In-Reply-To: <1205114703.656.115.camel@localhost>
Joe Perches wrote:
> On Sun, 2008-03-09 at 12:49 -0700, Joe Perches wrote:
>> diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
>> index ddc74d1..abf3c37 100644
>> --- a/drivers/char/synclink.c
>> +++ b/drivers/char/synclink.c
>> @@ -5413,9 +5410,9 @@ static void usc_process_rxoverrun_sync( struct mgsl_struct *info )
>>
>> if ( !start_of_frame_found )
>> {
>> - start_of_frame_found = TRUE;
>> + start_of_frame_found = true;
>> frame_start_index = end_index;
>> - end_of_frame_found = FALSE;
>> + end_of_frame_found = true;
>> }
>>
>> if ( buffer_list[end_index].status )
>
> end_of_frame_found should be false
OK the patch checks out (with the above fix).
Post the updated patch with a CC to Andrew
and I'll post an Acked-by response.
--
Paul Fulghum
Microgate Systems, Ltd.
next prev parent reply other threads:[~2008-03-10 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 7:09 [PATCH] drivers/char/synclink drivers/pcmcia/synclink - BOOLEAN to bool conversion Joe Perches
2008-03-09 15:06 ` Paul Fulghum
2008-03-09 19:49 ` [PATCH] synclink drivers " Joe Perches
2008-03-10 2:05 ` Joe Perches
2008-03-10 21:26 ` Paul Fulghum [this message]
2008-03-10 21:03 ` Joe Perches
2008-03-10 22:17 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5A793.9070105@microgate.com \
--to=paulkf@microgate.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.