From: Roel Kluin <12o3l@tiscali.nl>
To: jens.axboe@oracle.com
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] block/blk-merge.c: inverted likeliness in ll_back_merge_fn()
Date: Tue, 11 Mar 2008 02:35:41 +0100 [thread overview]
Message-ID: <47D5E1ED.3020804@tiscali.nl> (raw)
In my likely profile it appears this one is inverted.
---
Invert likeliness
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 0f58616..b17777a 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -305,7 +305,7 @@ int ll_back_merge_fn(struct request_queue *q, struct request *req,
}
if (unlikely(!bio_flagged(req->biotail, BIO_SEG_VALID)))
blk_recount_segments(q, req->biotail);
- if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
+ if (likely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
len = req->biotail->bi_hw_back_size + bio->bi_hw_front_size;
if (BIOVEC_VIRT_MERGEABLE(__BVEC_END(req->biotail), __BVEC_START(bio))
next reply other threads:[~2008-03-11 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 1:35 Roel Kluin [this message]
2008-03-11 6:11 ` [PATCH] block/blk-merge.c: inverted likeliness in ll_back_merge_fn() Jens Axboe
2008-03-11 8:18 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5E1ED.3020804@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.