All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Nicolas Pitre <nico@cam.org>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Fix incorrect wording in git-merge.txt.
Date: Tue, 11 Mar 2008 08:05:51 +0100	[thread overview]
Message-ID: <47D62F4F.8050106@op5.se> (raw)
In-Reply-To: <alpine.LFD.1.00.0803031519360.2899@xanadu.home>

Nicolas Pitre wrote:
> On Mon, 3 Mar 2008, Matthieu Moy wrote:
> 
>> Nicolas Pitre <nico@cam.org> writes:
>>
>>> You don't really merge a commit _object_.
>>> You merge with one or more other commits, tipycally identified by a 
>>> branch name or a tag.
>> Strictly speaking, you can merge any commit, not necessarily a branch
>> or a tag. That can be "git merge 66f0a4d" or whatever. Admitedly, the
>> common case is to merge a tag or a branch (which is why I keep it in
>> parentheses).
> 
> Yes, and I've been meaning the same all along.
> 
>> Now, I don't understand the distinction you seem to be making between
>> "commit" and "commit object".
> 
> Objects are what the low level storage is made of.  Conceptually, The 
> merge operation doesn't work at the object level, but rather at the 
> history graph level.  You don't merge objects, you merge history.
> I think it is unnecessary and probably best not to 
> mention the word "object" in this case.
> 
> The alternative is to provide more detailed explanation, such as:
> 
>    A merge is made by joining one or more history line to the current 
>    'HEAD' branch.  Those history lines are denoted by their terminating 
>    commit.  To identify them, the SHA1 name of the corresponding commit 
>    object is used, or more frequently the name of the branch or tag 
>    currently pointing at such commit objects.
> 

"... The SHA1 name or, more frequently, branch- or tag-names currently
pointing to such commits are used to identify them."

commit object = meta-data containing author/committer info, one or more
                parent links and a tree object describing the state of
                the tracked content

commit = A particular point in history.

At least afaiu.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

      parent reply	other threads:[~2008-03-11  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03 17:14 [PATCH] Fix incorrect wording in git-merge.txt Matthieu Moy
2008-03-03 17:27 ` Junio C Hamano
2008-03-03 17:52 ` Matthieu Moy
2008-03-03 18:26 ` Nicolas Pitre
2008-03-03 19:50   ` Matthieu Moy
2008-03-03 20:39     ` Nicolas Pitre
2008-03-03 21:25       ` Matthieu Moy
2008-03-03 22:10         ` Nicolas Pitre
2008-03-11  7:05       ` Andreas Ericsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D62F4F.8050106@op5.se \
    --to=ae@op5.se \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.