Re: nf_nat_core just using l3proto_find_get

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Mar 11 2008 15:05, Patrick McHardy wrote:
>>>>>         l3proto = nf_ct_l3proto_find_get((u_int16_t)AF_INET);
>>>>>
>>> [...]
>>> leading to the original question why nf_nat_core does not use
>>> nf_ct_l3proto_try_module_get.
>> Why should it? There's no need for manual module loading since
>> there already is a symbol dependency.
>>
> 
> According to `modinfo nf_nat`, nf_nat does not have a dependency
> on nf_conntrack_ipv4.

Right, that was iptable_nat.

> So what happens when nf_nat is loaded before nf_conntrack_ipv4?
> (Even if there are dependencies, this question is valid)
> 
> l3proto will be NULL, and is this ok?

No, it will break when translating ICMP errors.