From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl...
Date: Tue, 11 Mar 2008 23:43:47 +0100 [thread overview]
Message-ID: <47D70B23.6090805@bellard.org> (raw)
In-Reply-To: <47D7066B.80109@aurel32.net>
Aurelien Jarno wrote:
> Fabrice Bellard a écrit :
>> IMHO it would be much simpler to do all the tests in the block format
>> handlers.
>>
>
> Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
I suggest reverting the patch and writing correct tests in
block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good
indicator of the device size in case of removable devices for example.
Fabrice.
next prev parent reply other threads:[~2008-03-11 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 17:17 [Qemu-devel] qemu block-qcow.c block-qcow2.c block-vmdk.c bl Aurelien Jarno
2008-03-11 17:30 ` Fabrice Bellard
2008-03-11 22:23 ` Aurelien Jarno
2008-03-11 22:43 ` Fabrice Bellard [this message]
2008-03-11 23:15 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2008-03-11 23:30 Aurelien Jarno
2007-09-16 21:59 Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D70B23.6090805@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.