Re: [PATCH] genhd must_check warning fix

[Jeff Garzik <jeff@garzik.org>]

Roland McGrath wrote:
> Fixes:
> 
> 	block/genhd.c:361: warning: ignoring return value of ‘class_register’, declared with attribute warn_unused_result
> 
> Signed-off-by: Roland McGrath <roland@redhat.com>
> ---
>  block/genhd.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/block/genhd.c b/block/genhd.c
> index c44527d..00da521 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -360,7 +360,9 @@ static struct kobject *base_probe(dev_t devt, int *part, void *data)
>  
>  static int __init genhd_device_init(void)
>  {
> -	class_register(&block_class);
> +	int error = class_register(&block_class);
> +	if (unlikely(error))
> +		return error;
>  	bdev_map = kobj_map_init(base_probe, &block_class_lock);
>  	blk_dev_init();

ACK

I was silly and simply tuned out this warning, assuming [wrongly] that 
it was difficult to fix like the fs/partitions.c warning.

Shows how "helpful" those warnings are...

	Jeff