From: Tejun Heo <htejun@gmail.com>
To: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Subject: Re: [PATCH] libata: Register for dock events when the drive is inside a dock station
Date: Wed, 12 Mar 2008 14:15:57 +0900 [thread overview]
Message-ID: <47D7670D.1060600@gmail.com> (raw)
In-Reply-To: <20080311235548.GA4089@homac>
Hello, Holger.
Holger Macht wrote:
>> dev_notify is being registered with a pointer to ap. No wonder it causes
>
> It seems this change is missing from your patch. I've attached a fixed
> version...
Ah... I must have sent the wrong version of patch. Thanks for the fix.
>> strange dereferences later on. Attached is the fixed patch. Can you
>> please give it a shot?
>
> ...and now the good news...the new patch works flawlessly with
> 2.6.25-rc5...
>
> undocking...
> ata5.00: disabled
> ata5.00: detaching (SCSI 4:0:0:0)
> ACPI: \_SB_.GDCK - undocking
> usb 1-6: USB disconnect, address 5
>
> docking...
> ACPI: \_SB_.GDCK - docking
> ata5: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xa frozen
> ata5: ACPI event
> ata5: soft resetting link
> ata5.00: ATAPI: HL-DT-ST DVDRAM GSA-4083N, 1.08, max UDMA/33
> ata5.00: configured for UDMA/33
> ata5: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0x1 t4
> ata5: ACPI event
> ata5: soft resetting link
> ata5.00: configured for UDMA/33
> ata5: EH complete
> scsi 4:0:0:0: CD-ROM HL-DT-ST DVDRAM GSA-4083N 1.08 PQ: 0 ANSI: 5
> sr0: scsi3-mmc drive: 24x/24x writer dvd-ram cd/rw xa/form2 cdda tray
> sr 4:0:0:0: Attached scsi CD-ROM sr0
> sr 4:0:0:0: Attached scsi generic sg1 type 5
Super, I'll forward the patch upstream.
Thanks.
--
tejun
prev parent reply other threads:[~2008-03-12 5:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 12:40 [PATCH] libata: Register for dock events when the drive is inside a dock station Holger Macht
2008-02-14 12:56 ` Holger Macht
2008-02-20 17:11 ` Jeff Garzik
2008-02-21 11:53 ` Holger Macht
2008-02-22 1:34 ` Tejun Heo
2008-02-26 10:15 ` Holger Macht
2008-02-28 9:35 ` Tejun Heo
2008-02-28 11:09 ` Holger Macht
2008-02-28 13:05 ` Tejun Heo
2008-02-28 15:58 ` Holger Macht
2008-02-28 18:32 ` Holger Macht
2008-02-28 23:36 ` Holger Macht
2008-02-28 23:36 ` Holger Macht
2008-03-04 4:12 ` Tejun Heo
2008-03-11 23:55 ` Holger Macht
2008-03-12 5:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D7670D.1060600@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.